[MCC-1548828] Python Lib - Remove x-client-public-ip header from Python SDK Arrow Flight options [Dev Only] - #64
Open
glondhe-mdsol wants to merge 1 commit into
Open
glondhe-mdsol wants to merge 1 commit into
glondhe-mdsol wants to merge 1 commit into
Conversation
glondhe-mdsol
force-pushed
the
MCC-1548828
branch
from
September 10, 2026 13:11
fed1f10 to
ba3926b
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Add an explicit test assertion that x-client-public-ip is absent.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes x-client-public-ip header generation and socket-based IP discovery from the Python SDK Arrow Flight transport.
Changes:
- Removes public IP header injection and related socket logic.
- Removes obsolete IP-related tests and imports.
File summaries
| File | Reviewed change |
|---|---|
tests/test_logging_headers.py |
Header coverage does not explicitly assert that x-client-public-ip is absent. |
dataconnect/transport/arrow_flight/transport.py |
Removes socket-based IP header injection. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
glondhe-mdsol
marked this pull request as ready for review
September 10, 2026 15:26
glondhe-mdsol
force-pushed
the
MCC-1548828
branch
from
September 15, 2026 07:51
88f37ff to
a0c73f6
Compare
…t and related tests
glondhe-mdsol
force-pushed
the
MCC-1548828
branch
from
September 15, 2026 07:55
a0c73f6 to
8891972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor
Replace this line with Project title.MCC-1548828 - Python Lib - Remove x-client-public-ip header from Python SDK Arrow Flight options [Dev Only])Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary
Remove x-client-public-ip header from Python SDK Arrow Flight optionsDeployment Notes
In addition to IAC/code, add any notes for reviewer should know.